Optimize selector matching and clarify matcher contracts - #719
Open
andrewiggins wants to merge 8 commits into
Open
andrewiggins wants to merge 8 commits into
andrewiggins wants to merge 8 commits into
Conversation
andrewiggins
added this pull request to stack #721
September 17, 2026 16:46
This comment has been minimized.
This comment has been minimized.
andrewiggins
force-pushed
the
optimize-selectors
branch
from
September 22, 2026 00:08
efae8ca to
94720bd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idandclassattributes directly without redundant name normalization, and inline the remaining attribute lookup.A shared
htmlNameproperty holds precomputed HTML names and is required for element and attribute matchers.namepreserves the original spelling for foreign-element matching, whilevalueretains the selector payload. Parser construction uses the property ordertype,name,htmlName,value. Matcher arrays andNodeListquery results are unchanged.This is the lower layer of the stack. It leaves
getElementsByTagName()and its tests unchanged; #720 adds qualified-name matching and reuses the optimized engine for that lookup.Validation
Stack created with GitHub Stacks CLI • Give Feedback 💬