Repository navigation
Validate enum keys before serialization - #186
Merged
Merged
Conversation
Co-authored-by: River <river@shopify.com>
madmath
marked this pull request as ready for review
October 29, 2026 15:15
Contributor
Author
|
@stephanie-shopify could you review this change? Please see the description for compatibility questions and verification limitations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep inline enum arguments within GraphQL's Name grammar.
This package is deprecated. Maintainer review is needed; whether to ship a change remains a maintainer decision. Previously accepted malformed keys now throw synchronously, including during response decoding, so compatibility needs review. This does not add schema-membership validation.
Verification with the repository's existing Babel/Rollup toolchain on Node 22.15.0 and Yarn 1.22.22:
npm test: 276 passing on unchanged master; 277 passing / 1 expected failure with only the new tests; 278 passing with the fix, including lint checks.npm run build:devandnpm run build:prod: pass with legacy toolchain warnings.git diff --check: pass.The pinned Node 8.15.0 runtime could not run on this machine; browser tests were not run.