Repository navigation
Prevent web checkout lifecycle events from bubbling - #969
Merged
Merged
Conversation
Coverage Report
|
Bundle Size Budgets
Bundle and package sizeWeb bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.
Web package files (uncompressed)These are uncompressed file sizes; they do not sum to the compressed package size above.
How sizes are measuredMeasured from the PR base SHA and PR head SHA. Web bundle rows sum shipped |
westeezy
approved these changes
Oct 9, 2026
westeezy
left a comment
Contributor
There was a problem hiding this comment.
LGTM i dont think we need bubble behavior so this is excellent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkout lifecycle events currently bubble to ancestor listeners, which can trigger unrelated handlers for generic event names such as
closeandupdate.Set
bubbles: falseforstart,update,complete,close, andblocked, matching the existingerrorevent. Consumers must attach listeners directly to<shopify-checkout>; delegated bubbling listeners on ancestors ordocumentwill no longer receive these events.Update the lifecycle documentation and existing blocked-event propagation test to match.