Repository navigation
Move the CDN deploy out of the public release workflow - #968
Merged
Merged
Conversation
Bundle Size Budgets
Bundle and package sizeWeb bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.
How sizes are measuredMeasured from the PR base SHA and PR head SHA. Web bundle rows sum shipped |
The release workflow goes back to publishing npm only. It still builds and verifies the CDN output so CI proves the artefacts, but the upload to the CDN now runs from Shopify's internal release tooling, triggered with the release tag after npm publication. That deploy rebuilds from the tag, refuses to deploy a version npm does not have, and reuses the kit's channel policy script. Docs updated; the environment secrets added for the in-repo upload are no longer needed.
kiftio
force-pushed
the
dk/web-publish-npm-only
branch
from
October 9, 2026 14:28
c990ecb to
3c5c674
Compare
markmur
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
The CDN upload is moving out of this workflow and into Shopify's internal release tooling; this repository's release workflow goes back to publishing npm only.
web-publish.ymlgoes back to npm-only (about 150 lines removed): the auth, pre-flight, bucket-permission check, redeploy guard and upload steps are gone. It still runsbuild:cdnandverify, so CI proves the CDN artefacts build and the built-package tests keep covering both distributions.npm publish --ignore-scriptsstays.dist-cdn/, refuses to deploy a version npm does not have, reads the npm dist-tag back, runs this repo'sscripts/cdn-release-policy.mjsfor the channel, and uploads chunks before the loader. Re-triggering with an older tag is rollback.CDN-PUBLISHING.md"Publishing" rewritten for the two-step flow;RELEASING.mdgains a "Deploy the CDN assets" step and the bad-deploy runbook points at re-triggering the deploy; the environment-secrets section is removed.After merge: the four
CDN_*secrets on thenpm-webenvironment are unused and can be deleted.web/4.0.0-alpha.5will be the first release to go through the tag path; earlier alphas were published by manual dispatch without tags.How to test
No runtime code changes; workflow and docs only.
Before you merge
Important