Repository navigation
Conversation
This was referenced Oct 8, 2026
Bundle Size Budgets
Bundle and package sizeWeb bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.
How sizes are measuredMeasured from the PR base SHA and PR head SHA. Web bundle rows sum shipped |
markmur
added this pull request to stack #949
October 8, 2026 11:48
markmur
force-pushed
the
aggregate-javascript-coverage
branch
from
October 8, 2026 11:59
6c789c9 to
3081ce2
Compare
markmur
force-pushed
the
aggregate-javascript-coverage
branch
from
October 8, 2026 17:06
3081ce2 to
c2ec679
Compare
Contributor
Author
Coverage Report
|
kiftio
reviewed
Oct 9, 2026
| [platform.id, platformResult(platform, snapshot, jobs, pr, repo, core)])); | ||
| const body = render(results); | ||
| const comments = await github.paginate(github.rest.issues.listComments, {...repo, issue_number: pr.number, per_page: 100}); | ||
| const existing = comments.find(isComment); |
Contributor
There was a problem hiding this comment.
I think we could skip the comment for changes that don't touch JS via something like
const existing = comments.find(isComment);
// Don't open a comment until we know at least one JS platform is in scope.
// Existing comments still update so stale numbers get replaced.
const plan = latest(jobs.filter((item) => item.name === "Detect Changed Areas"));
const inScope = Object.values(results).some((result) => result.state !== "skipped");
if (!existing && (plan?.status !== "completed" || !inScope)) return;This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the separate Web, React Native JavaScript, and Embedded Checkout Protocol (TS) comments with one compact Coverage Report table. Show status emojis, coverage percentages, and full-report links using the existing JavaScript test coverage.
Platform jobs save structured results in GitHub checks. A single publisher reloads current results and serializes comment updates, matching the commit, workflow, and rerun attempt. Pending, skipped, failed, and unavailable results remain visible.
The publisher runs trusted default-branch code and validates numeric results. Automatic aggregate comments begin once its workflow reaches main. Native coverage collection and reporting are added separately in #924.
Continues #926, which GitHub marked merged into its previous stack base during reordering. The aggregation change has not landed on
main.Stack