Repository navigation
fix(webhooks): make client_identity optional and nullable throughout - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webhook receivers must not depend on client attribution being available or complete. client_identity now accepts omission or null, and every nested field is optional and nullable, including fields inside claims, verified, assessments and evidence.
A dedicated WebhookClientIdentity schema documents this best-effort contract without relaxing the stored identity model used by other API surfaces. Known non-null values keep their type validation. Distribution schemas are rebuilt; Core emission does not need to change because its existing output remains valid.
Validation: npm run bundle, npm run lint, npm test (76 passing). Regression checks missing/null object, empty object, null nested fields and partial array items; invalid non-null types remain rejected.