[BUG] Disable Auto Joining Raids does not prevent Twitch redirect (Firefox, 7TV 1.10.0) #1264

Activity

1. github-project-automation

   added this to 7TV Extensionon Sep 27, 2026
2. github-project-automation

   moved this to Available in 7TV Extensionon Sep 27, 2026
3. lansman commented on Oct 2, 2026

   

   lansman

   on Oct 2, 2026

   Author

   More actions

   I investigated this against the official Firefox packages for 7TV New 1.7.2, 1.10.0, and 1.10.2, and compared the implementation with current FrankerFaceZ and BetterTTV.

   The failure is in 7TV's React component lookup, before the actual raid handling runs.

   RaidAutojoinModule registers its component hook with the equivalent of:

   {
     childSelector: "#root",
     predicate: isRaidController,
     maxDepth: 300,
   }

   However, the shared React hook resolver treats childSelector as a DOM element rendered below the target component and therefore walks up the Fiber chain via fiber.return. It treats parentSelector as a container and scans down through child/sibling fibers.

   Twitch's #root is the React root container and RaidController is below it. As a result, the current lookup walks in the wrong direction, finds no RaidController, and never installs the handleJoinRaid wrapper or calls handleLeaveRaid(). This explains why the setting remains enabled in the UI but has no effect.

   There is a second issue in the same resolver: the downward (parentSelector) branch calls the descendant traversal without forwarding maxDepth, so it silently uses the helper default of 100 instead of the requested 300.

   The relevant logic is unchanged in the 1.7.2, 1.10.0, and 1.10.2 Firefox bundles. I also reproduced both lookup failures with a synthetic Fiber tree.

   This does not look like a current Twitch RaidController API regression:

   • FrankerFaceZ currently uses the same handleJoinRaid, handleLeaveRaid, hasJoinedCurrentRaid, and isRaidCreator contract: https://github.com/FrankerFaceZ/FrankerFaceZ/blob/master/src/sites/twitch-twilight/modules/chat/index.js#L2090-L2135
   • BetterTTV avoids React internals entirely: it observes [data-test-selector="raid-banner"] and clicks the leave button: https://github.com/night/betterttv/blob/master/src/modules/auto_join_raids/index.js

   Suggested fix:

   1. Change the root lookup to parentSelector: "#root".
   2. Forward { maxDepth: selector.maxDepth ?? 100 } to the descendant Fiber traversal.

   Alternatively, a more resilient implementation would observe [data-test-selector="raid-banner"] and find the owning component upward from that DOM node, similar in spirit to BetterTTV's approach. That avoids scanning the entire Twitch root and reduces dependence on tree depth.