Add Spanish localization for the application#51
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughSpanish localization is added through a complete Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
locales/es.json (1)
1-98:⚠️ Potential issue | 🔴 CriticalCritical: Spanish locale file added but Rust i18n system cannot load or access it.
The
locales/es.jsonfile is added in isolation. However, the Rust i18n infrastructure (src/i18n/mod.rsandsrc/components/lang_switcher.rs) remains unchanged and does not support Spanish. This blocks the locale from being loaded, selected, or used at runtime.Evidence of incomplete integration:
- Lang enum (
src/i18n/mod.rs:29-31) defines onlyEn,Id,Zh—noEsvariant.Lang::ALLcontains exactly 3 items.- Lang::raw() (lines 65-70) uses
include_str!()only foren.json,id.json,zh.json—noes.json.- Lang::from_code() (lines 58-63) has only
"id"and"zh"cases; all other strings (including"es") fall back toLang::En:_ => Self::En.- Lang::code(), label(), full_label() (lines 34-56) have no
Esmatch arm, so Spanish has no code, label, or display name.- Static maps (lines 72-74) and map_for() (lines 75-96) define only
EN_MAP,ID_MAP,ZH_MAP—noES_MAPand noLang::Escase.- LanguageSwitcher (
src/components/lang_switcher.rs:12-18) cyclesEn → Id → Zh → En—noEscase, making Spanish unreachable to users.Consequence: Even though the JSON file is present, the locale cannot be loaded, selected, or accessed at runtime.
PR claim vs. reality: The PR objectives state the implementation "follows the established pattern used in existing locale files," and the test plan states: "verifying that the language selector can switch to 'Español'". However, neither is achievable without Rust code changes.
Action required: Update
src/i18n/mod.rsto:
- Add
Esto theLangenum.- Implement
Escase incode()→"es",label()→"ES",full_label()→"Español".- Update
Lang::from_code()to match"es" => Self::Es.- Add
include_str!("../../locales/es.json")inLang::raw()forEs.- Add
ES_MAPstatic and handle it inmap_for().Update
src/components/lang_switcher.rsto includeEsin the cycle:En → Id → Zh → Es → En.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@locales/es.json` around lines 1 - 98, The Spanish locale JSON file was added but the Rust i18n system was not updated to support it, making the locale inaccessible at runtime. Add the `Es` variant to the `Lang` enum and implement all required methods for it: add the `"es"` case to `Lang::from_code()`, implement the `code()` method to return `"es"`, implement `label()` to return `"ES"`, implement `full_label()` to return `"Español"`, include the Spanish JSON file via `include_str!()` in `Lang::raw()` for the `Es` variant, create an `ES_MAP` static following the existing pattern of `EN_MAP`, `ID_MAP`, and `ZH_MAP`, and add the `Lang::Es` case to the `map_for()` method. Additionally, update the `LanguageSwitcher` component's language cycling logic to include `Es` in the rotation sequence so users can switch to Spanish through the UI.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@locales/es.json`:
- Around line 1-98: The Spanish locale JSON file was added but the Rust i18n
system was not updated to support it, making the locale inaccessible at runtime.
Add the `Es` variant to the `Lang` enum and implement all required methods for
it: add the `"es"` case to `Lang::from_code()`, implement the `code()` method to
return `"es"`, implement `label()` to return `"ES"`, implement `full_label()` to
return `"Español"`, include the Spanish JSON file via `include_str!()` in
`Lang::raw()` for the `Es` variant, create an `ES_MAP` static following the
existing pattern of `EN_MAP`, `ID_MAP`, and `ZH_MAP`, and add the `Lang::Es`
case to the `map_for()` method. Additionally, update the `LanguageSwitcher`
component's language cycling logic to include `Es` in the rotation sequence so
users can switch to Spanish through the UI.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8f277b9e-a327-405c-bbb6-335f3134c7ad
📒 Files selected for processing (1)
locales/es.json
satyakwok
left a comment
satyakwok
left a comment
There was a problem hiding this comment.
Gracias — the Spanish strings themselves look great (full key parity with en.json, idiomatic). One thing before it can ship: locales/es.json isn't picked up yet on its own. The locale set is enumerated in src/i18n/mod.rs (the Lang enum + code() / from_str() / content() arms, all currently En/Id/Zh), and the LanguageSwitcher cycles a fixed three. To make Spanish selectable, please also:
- add
Esto theLangenum - add the
"es"arms tocode(),from_str(), andcontent()(include_str!("../../locales/es.json")) - extend
LanguageSwitcherso it includes Spanish in the cycle
With those, the es.json you added wires up. Thanks for adding the locale!
|
Thanks @satyakwok! Right, the |
|
@satyakwok pushed — es is now wired up end to end: Es added to the Lang enum and ALL, "es" arms added to code(), label() (ES), full_label() (Español), from_code(), and raw() with include_str!("../../locales/es.json"), plus an ES_MAP OnceLock and the map_for arm. LanguageSwitcher now cycles En → Es → Id → Zh → En, and the module docs reflect the four locales. Ready for another look. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/i18n/mod.rs`:
- Around line 1-10: Update the LanguageSwitcher cycle in the lang switcher
component so the Lang match includes Spanish in the order En → Es → Id → Zh →
En, and persist the selected locale through the existing persist_lang flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e93e2f05-ec2e-4f74-9f3c-ab6a697c0be8
📒 Files selected for processing (1)
src/i18n/mod.rs
2 participants
Summary
Adds
locales/es.json— a complete Spanish (Español) translation of the explorer UI. All 97 i18n keys fromlocales/en.jsonare translated, keeping keys identical and only translating the values.Closes #50
Test plan
Related
Follows the same pattern as the existing
locales/id.jsonandlocales/zh.jsonlocale files.Summary by CodeRabbit