Fix multi-byte Unicode input (CJK/emoji)#6
Open
keyuchen21 wants to merge 1 commit into
Open
Conversation
The raw input reader was reading stdin one byte at a time and immediately decoding, which corrupted multi-byte UTF-8 characters into replacement characters (U+FFFD). Now inspects the lead byte to determine continuation byte count before decoding. Also fixes display width calculations — CJK characters occupy 2 terminal columns but were treated as 1, causing cursor misalignment and broken box-drawing in the input editor.
Author
Author
VerificationTested manually — Chinese input now works correctly: Before fix: typing "你好" produced "������" (each UTF-8 byte decoded separately as replacement characters) After fix: "你好" displays correctly in the input box with proper cursor positioning and box alignment Test results:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
_raw_read_key()was reading one byte at a time and immediately decoding, corrupting multi-byte UTF-8 sequences into replacement characters (������)_raw_read_available()(used for escape sequences and paste) now accumulates raw bytes before decoding, fixing pasted CJK textTest plan