Repository navigation
Refactor: Clean up app initialization and connection handling - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__init__instead ofrun()for better testabilitySendspinAppandSendspinDaemonDiscoveredServerobjects throughout instead of raw URLsChanges
CLI Layer (
cli.py)_resolve_client_info()to centralize client ID/name resolution with proper error handling_run_daemon_modeand_run_client_modeasync, with singleasyncio.run()at entry pointApp Initialization
SendspinAppandSendspinDaemonnow createSendspinClient,AudioStreamHandler,ServiceDiscovery, andConnectionManagerin__init__AppConfigandDaemonConfignow requireclient_idandclient_name(no longer optional)SendspinUInow takesdelay_msin constructorConnection Handling
connection_loopfrom standalone function to_connection_loopmethod onSendspinApp_handle_metadata_update,_handle_group_update, etc.) to methodsConnectionManagerby usingDiscoveredServerobjects instead of URL stringsDiscovery (
discovery.py)DiscoveredServer.from_url()factory method for creating server objects from CLI URLscurrent_url()andwait_for_first_server()with unifiedwait_for_server()that returnsDiscoveredServer_current_urltrackingOther
sleep_interruptibleusingasyncio.waitwith timeout instead of polling loop__init__Result
~125 lines removed while improving code organization and testability.