Skip to content

fix(deps): require patched aiohttp and Pillow - #66

Closed
BowenFu wants to merge 2 commits into
SemiAnalysisAI:masterfrom
BowenFu:BowenFu/aiohttp-security
Closed

BowenFu wants to merge 2 commits into
SemiAnalysisAI:masterfrom
BowenFu:BowenFu/aiohttp-security

Conversation

@BowenFu

@BowenFu BowenFu commented Oct 29, 2026 •

Copy link
Copy Markdown

Require aiohttp~=3.14.4 and pillow~=13.0.0 for their security fixes. Preserve existing custom-image behavior: Pillow 13 rejects 32-bit integer PNG encoding, so convert mode I to I;16 with the same clipping Pillow 12 used. Python and minor-series bounds remain unchanged.

Validation:

  • Three focused cases cover integer pixels, input immutability and real TIFF resize/PNG/JPEG encoding. Both PNG cases fail before the fix and pass afterward; the original Pillow 12.2 control passes.
  • Four PNG outputs match the original Pillow 12.2 bytes and pixels exactly.
  • Dataset/plot coverage: 3,785 passed across the initial run and unchanged setup retries; five skips and one expected failure remain. The 24 initial failures came from the disposable container's missing user home.
  • Pre-commit passed. Prior full dependency validation retains its two documented baseline failures.

No performance claim.

Signed-off-by: Bowen Fu <5812640+BowenFu@users.noreply.github.com>
@BowenFu
BowenFu requested a review from FrankD412 as a code owner October 29, 2026 21:38
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Try out this PR

Quick install:

pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@779feae3741d639e5cdcaafb1e99f41cda15c8c6

Recommended with virtual environment (using uv):

uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@779feae3741d639e5cdcaafb1e99f41cda15c8c6

Last updated for commit: 779feae • Browse code

@github-actions github-actions Bot added the fix label Oct 29, 2026
@BowenFu
BowenFu marked this pull request as draft October 30, 2026 02:45
@BowenFu
BowenFu marked this pull request as ready for review October 30, 2026 02:52
Convert mode I images to I;16 before PNG encoding, preserving the
clipping and bytes produced by Pillow 12. Cover signed pixel bounds,
source-image immutability and the custom TIFF resize/encode path.

Follows the compatibility fix in ai-dynamo/aiperf@5222c1a.

Signed-off-by: Bowen Fu <5812640+BowenFu@users.noreply.github.com>
@BowenFu

BowenFu commented Oct 30, 2026

Copy link
Copy Markdown
Author

Withdrawn. The TensorRT-LLM consumer integration is tracked in NVIDIA/TensorRT-LLM#21322. I am closing this upstream PR to keep the work scoped to TensorRT-LLM. The source commits remain available.

@BowenFu BowenFu closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant