refactor(attestation)!: drop the Azure outdated-TCB override - #267
Merged
Conversation
The attested-tls backend can rewrite one Azure FMSPC's TCB Info so a component's required SVN clamps down to the platform's, letting a platform behind every published TCB level match one. We forwarded that as `VerifyOptions::override_azure_outdated_tcb` and as an `--override-azure-outdated-tcb` flag on verify-quote and the two examples. No Seismic relying party should take it. It makes a verdict depend on a caller's flag rather than on the evidence and the collateral, so the same quote verifies for one operator and fails for another. Founding evidence that is archived for later re-verification must not carry that ambiguity. Remove the field and the flags; the backend is now always constructed with the override off. A platform that Intel rates OutOfDate fails verification, as it should, and any allowance for it belongs in the measurement policy, not on argv. BREAKING: `VerifyOptions` loses `override_azure_outdated_tcb`; `verify-quote`, `capture_measurements` and `azure_vtpm_roundtrip` no longer accept `--override-azure-outdated-tcb`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attested-tls backend can rewrite one Azure FMSPC's TCB Info so a component's required SVN clamps down to the platform's, letting a platform behind every published TCB level match one. We forwarded that as
VerifyOptions::override_azure_outdated_tcband as an--override-azure-outdated-tcbflag on verify-quote and the two examples.No Seismic relying party should take it. It makes a verdict depend on a caller's flag rather than on the evidence and the collateral, so the same quote verifies for one operator and fails for another. Founding evidence that is archived for later re-verification must not carry that ambiguity.
Remove the field and the flags; the backend is now always constructed with the override off. A platform that Intel rates OutOfDate fails verification, as it should, and any allowance for it belongs in the measurement policy, not on argv.
BREAKING:
VerifyOptionslosesoverride_azure_outdated_tcb;verify-quote,capture_measurementsandazure_vtpm_roundtripno longer accept--override-azure-outdated-tcb.