Repository navigation
[New Feature] Silent Payment - #949
Draft
notTanveer wants to merge 6 commits into
Draft
notTanveer wants to merge 6 commits into
notTanveer wants to merge 6 commits into
Conversation
notTanveer
force-pushed
the
sp-send-support
branch
from
August 10, 2026 14:15
47ea5ba to
2d96357
Compare
notTanveer
force-pushed
the
sp-send-support
branch
from
August 10, 2026 16:12
2d96357 to
0d8ce33
Compare
notTanveer
force-pushed
the
sp-send-support
branch
3 times, most recently
from
August 24, 2026 13:26
cb05960 to
c5c29fc
Compare
notTanveer
force-pushed
the
sp-send-support
branch
from
October 3, 2026 16:22
c5c29fc to
ac6d87e
Compare
embit dropped has_sp_content/has_sp_spend_inputs and the has_sp_outputs kwarg on get_eligible_inputs, and now verifies any declared PSBT_OUT_SCRIPT against the derived Silent Payment output at signing time. Reconstruct the removed helpers in PSBTParser, drop the stale kwarg, and switch QR-type detection to a magic-bytes check instead of a full vanilla-PSBT parse so an unresolved SP output (the realistic coordinator hand-off state) is still detected correctly. Co-authored-by: macgyver13 <4712150+macgyver13@users.noreply.github.com>
notTanveer
force-pushed
the
sp-send-support
branch
from
October 3, 2026 16:23
ac6d87e to
3ac9181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Silent Payments support to SeedSigner. #569
With these changes, SeedSigner can now sign Silent Payment (sp1) transactions using Sparrow as the coordinator. I've tested the implementation end-to-end, and existing transaction flows (including non-Silent Payment sends) continue to work as expected.
Additional Information
This PR is currently marked as a draft because it depends on the upstream embit changes in PR #145:
Until that PR is merged, we can't move forward with this implementation. I would urge to review the upstream PR as well it will help get this implementation across the finish line. rn, i have tested built it on top of embit fork.
Screenshots
This pull request is categorized as a:
Checklist
I ran
pytestlocallyI included screenshots of any new or modified screens
Should be part of the PR description above.
I added or updated tests
Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.
I tested this PR hands-on on the following platform(s):