Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem or Issue being addressed
Fixes #1081.
A
ur:crypto-accountQR containing a multisig output decodes completely, butDecodeQR.is_wallet_descriptorreturnsFalse, soget_wallet_descriptor()returnsNone. The same output encoded asur:crypto-outputworks.Solution
Add
QRType.ACCOUNT__URto the types checked inis_wallet_descriptor. The code that extracts the descriptor from a crypto-account already exists inget_wallet_descriptor(); it was just never reached.Added a test that decodes a 2-of-2 multisig crypto-account QR and checks it is recognised as a wallet descriptor. It fails without the fix and passes with it.
Additional Information
get_wallet_descriptor()still uses the first output descriptor in the account. That behaviour is unchanged here.Screenshots
N/A, no screens changed.
This pull request is categorized as a:
Checklist
I ran
pytestlocallyThe new test passes. On my Windows setup, 8 tests in
test_l10n.pyandtest_seedqr.pyfail, but they fail the same way ondevwithout this change.I included screenshots of any new or modified screens
I added or updated tests
I tested this PR hands-on on the following platform(s):
I have reviewed these notes: