Skip to content

Recognise crypto-account QRs as wallet descriptors - #1082

Open
raus7n wants to merge 1 commit into
SeedSigner:devfrom
raus7n:fix-crypto-account-descriptor
Open

raus7n wants to merge 1 commit into
SeedSigner:devfrom
raus7n:fix-crypto-account-descriptor

Conversation

@raus7n

@raus7n raus7n commented Nov 16, 2026

Copy link
Copy Markdown

Description

Problem or Issue being addressed

Fixes #1081.

A ur:crypto-account QR containing a multisig output decodes completely, but DecodeQR.is_wallet_descriptor returns False, so get_wallet_descriptor() returns None. The same output encoded as ur:crypto-output works.

Solution

Add QRType.ACCOUNT__UR to the types checked in is_wallet_descriptor. The code that extracts the descriptor from a crypto-account already exists in get_wallet_descriptor(); it was just never reached.

Added a test that decodes a 2-of-2 multisig crypto-account QR and checks it is recognised as a wallet descriptor. It fails without the fix and passes with it.

Additional Information

get_wallet_descriptor() still uses the first output descriptor in the account. That behaviour is unchanged here.

Screenshots

N/A, no screens changed.


This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

I ran pytest locally

  • All tests passed before submitting the PR
  • I couldn't run the tests
  • N/A

The new test passes. On my Windows setup, 8 tests in test_l10n.py and test_seedqr.py fail, but they fail the same way on dev without this change.


I included screenshots of any new or modified screens

  • Yes
  • No
  • N/A

I added or updated tests

  • Yes
  • No, I’m a fool
  • N/A

I tested this PR hands-on on the following platform(s):


I have reviewed these notes:

  • Keep your changes limited in scope.
  • If you uncover other issues or improvements along the way, ideally submit those as a separate PR.
  • The more complicated the PR, the harder it is to review, test, and merge.
  • We appreciate your efforts, but we're a small team of volunteers so PR review can be a very slow process.
  • Please only "@" mention a contributor if their input is truly needed to enable further progress.
  • I understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crypto-account multisig QR is not recognised as a wallet descriptor

1 participant