Repository navigation
feat(views): enable passphrase addition and editing from seed options menu (fixes #1031) - #1069
Open
muskan-creates352 wants to merge 1 commit into
Open
muskan-creates352 wants to merge 1 commit into
muskan-creates352 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem or Issue being addressed
Currently, users are only prompted to add a BIP39 passphrase immediately after they generate or load a seed. If a user skips this step, accidentally makes a typo, or decides to apply/change a passphrase later, they are forced to discard the active seed and restart the entire process (e.g. re-entering 99+ dice rolls or scanning the seed again).
Fixes #1031
Solution
SeedOptionsView:"Add Passphrase"when no passphrase is set, or"Edit Passphrase"when a passphrase already exists).SeedPassphraseView&SeedOptionsFlow:tests/test_flows_seed.py):Additional Information
Screenshots
N/A (Standard SeedOptions menu item re-using existing keyboard and warning views).
This pull request is categorized as a:
Checklist
I ran
pytestlocallyI included screenshots of any new or modified screens
I added or updated tests
I tested this PR hands-on on the following platform(s):
I have reviewed these notes: