Skip to content

feat(views): enable passphrase addition and editing from seed options menu (fixes #1031) - #1069

Open
muskan-creates352 wants to merge 1 commit into
SeedSigner:devfrom
muskan-creates352:add-passphrase-seed-options-menu
Open

muskan-creates352 wants to merge 1 commit into
SeedSigner:devfrom
muskan-creates352:add-passphrase-seed-options-menu

Conversation

@muskan-creates352

@muskan-creates352 muskan-creates352 commented Nov 1, 2026 •

Copy link
Copy Markdown

Description

Problem or Issue being addressed

Currently, users are only prompted to add a BIP39 passphrase immediately after they generate or load a seed. If a user skips this step, accidentally makes a typo, or decides to apply/change a passphrase later, they are forced to discard the active seed and restart the entire process (e.g. re-entering 99+ dice rolls or scanning the seed again).

Fixes #1031

Solution

  1. SeedOptionsView:
    • Added a dedicated menu option ("Add Passphrase" when no passphrase is set, or "Edit Passphrase" when a passphrase already exists).
    • Dynamically routed to the passphrase keyboard and warning flow while keeping the base seed active in memory.
  2. SeedPassphraseView & SeedOptionsFlow:
    • Handled passphrase application and state updates so the derived master keys and fingerprints are recomputed accurately without discarding the base entropy.
  3. Tests (tests/test_flows_seed.py):
    • Added flow tests verifying both adding a passphrase to a loaded seed and updating an existing passphrase from the options menu.

Additional Information

  • Existing seed loading and passphrase setup flows remain intact.

Screenshots

N/A (Standard SeedOptions menu item re-using existing keyboard and warning views).


This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

I ran pytest locally

  • All tests passed before submitting the PR
  • I couldn't run the tests
  • N/A

I included screenshots of any new or modified screens

  • Yes
  • No
  • N/A

I added or updated tests

  • Yes
  • No, I’m a fool
  • N/A

I tested this PR hands-on on the following platform(s):


I have reviewed these notes:

  • Keep your changes limited in scope.
  • If you uncover other issues or improvements along the way, ideally submit those as a separate PR.
  • The more complicated the PR, the harder it is to review, test, and merge.
  • We appreciate your efforts, but we're a small team of volunteers so PR review can be a very slow process.
  • Please only "@" mention a contributor if their input is truly needed to enable further progress.
  • I understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Enable Passphrase Addition/Editing Directly from the Seed Options Menu

1 participant