Repository navigation
Answers spec v1.4: param_bounds + upcoming calendars fetch from today forward - #12
Open
SecureCloudGroup wants to merge 1 commit into
Open
SecureCloudGroup wants to merge 1 commit into
SecureCloudGroup wants to merge 1 commit into
Conversation
…ell), authored for the USGS quake sources; upcoming calendars fetch from today forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 20, Q3b (the app's query layer) needs two Library changes.
param_bounds(answers spec v1.4, optional, closed): on alist/columnsanswer,{<cell path>: {min?: <param>, max?: <param>}}names the address parameter that bounds anumbercell from below or above, so the app can push an asked comparator into the address ("earthquakes above magnitude 4" fetches withminmagnitude=4instead of the default 2.5) while the card's own row filter stays. Validation inanswers.py(the cell is one of the answer's number fields, each side names a numeric parameter of the record, one parameter bounds one side of one cell). Authored forusgs-quakes-stateandusgs-quakes-near(properties.mag←min_mag).docs/SCHEMA.mddocuments it.mlb-team-scheduleandfinnhub-earnings-calendarfilled their date window at −30/0 days while theirnext_*/upcominganswers read the first row, so every "next game" was a game already played. The clock fill is now 0/+30 for both, as a provider rule infills.pyso a futurefillsrun keeps it, plus the two record lines. Live check: the old window returned a Sept 9 game first for every MLB team; the new one returns the next scheduled game.Gate (Docker,
smartbrain_3000:dev): build 8,672 sources; check 8,674 records, 259 with answers, 0 invalid; lint 0; evallookup 46/46; pytest 268 passed (one new test per change).answers-checkpasses on both edited answers files.