Repository navigation
Answers round 2 after the SET C/D reads: snow in the hourly answer, next high/low tide, Kp unit, 5-cell cap - #11
Merged
Conversation
…ext high/low tide, Kp unit, 5-cell cap open-meteo-forecast: the hourly tonight answer gains a Snowfall cell (the url_template and sample URL request hourly snowfall) and keeps its temperature, so the per-answer cell cap rises from 4 to 5 (messages, tests, recorded sample). coops-tide-hilo: next_high / next_low answers filtered on the H/L type cell with their words; the generic tides answer keeps the whole list. swpc-kp-forecast: Kp unit on the three cells. Keyword-lint baseline: the stale 'tide table' entry dropped. Gate: build 0 invalid, lint 0 problems, answers-check PASS on the three sources, evallookup 46/46, pytest 266.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers round 2 after the SET C/D reads: snow in the hourly answer, next high/low tide, Kp unit, 5-cell cap
Pairs with SmartBrain_3000 PR SecureCloudGroup/SmartBrain_3000#499 (data-layer round 2).
open-meteo-forecast: the hourly "Tonight, hour by hour" answer gains aSnowfallcell (hourly.snowfall, unit fromhourly_units.snowfall); the record'surl_templateand the answer's sample URL requesthourly=…,snowfall; the answer keeps Time, Conditions, Temperature and Rain chance, so the per-answer cell cap rises from 4 to 5 (sourcetool/answers.py, messages and tests; the app raised its cap in step). The recorded test sample gains thehourly.snowfallarray.coops-tide-hilo:next_highandnext_lowlist answers filtered on the type cell (H/L) with the words "next high tide", "high tide", "next low tide", "low tide"; thetidesanswer's words trimmed to the generic ones so "next low tide" picks the low rows (scored by hand: 4.0 vs 2.0) and "tide times for Galveston on Friday" keeps the whole list. The URL already asked for station local time.swpc-kp-forecast:unit: "Kp"on the three Kp cells.Gate (Docker,
smartbrain_3000:dev)sourcetool build8,672 sources, 0 invalid ·check0 invalid ·answers-check --lint0 problems (469 held by the baseline) ·answers-checkPASS on open-meteo-forecast (12 answers), coops-tide-hilo (5), swpc-kp-forecast (3) ·evallookuptop-1 46/46 · pytest 266 passed.