Repository navigation
Words round after the SET C live read: sun rise, advisories/watches, GDP naming - #10
Merged
Merged
Conversation
…GDP naming sky/sun_moon keywords sun rise / sun rises / sun up / sunup; weather/alerts advisories / watches; the sunrise answers say sun rise and sunup; the GDP level record names GDP, declares current_value beside trend and describes the headline number, the growth-rate record carries entity GDP so the bare entity lift no longer decides between them. Gate: check 0 invalid, lint 0 problems, evallookup 46/46, pytest 266.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Words round after the SET C live read: sun rise, advisories/watches, GDP naming
Three SET C asks the app could have served went to links, and one tapped the level series for a growth ask. The app's classifier and ranking explained each; these are the data-side fixes (the app side is SmartBrain_3000 PR SecureCloudGroup/SmartBrain_3000#497).
sky/sun_moon: keywordssun rise,sun rises,sun up,sunup(it already hadsun set,sun come up): "what time does the sun rise in Anchorage tomorrow" classified only to time/time_zones and found no source.weather/alerts: keywordsadvisories,watches, so the Library's own lookup matches the plural without relying on the app's fold.open-meteo-sun:sunrise_todaywords +=sun rise,sunup;sunrise_tomorrow+=sun rise tomorrow(the keyword lint needs a filed source to speak each keyword;sunupwas flagged until the words carried it).fred-gdp/fred-a191rl1q225sbea: the level record is named "GDP, gross domestic product (FRED)", describes "the latest quarter and its history", declarescurrent_valuebesidetrend(itslatestanswer serves one), examples "US GDP", "GDP level", "nominal GDP"; the growth-rate record describes the annualized quarterly change, carriescoverage.entity"GDP" and examples "gdp growth", "are we in a recession", "economic growth". Before, the level record's bare entity "GDP" earned a named-entity lift the growth record never got, and its name lacked the acronym, so "US GDP growth trend" ranked the level first; now the growth ask ranks the growth-rate series first and the bare "US GDP" ask the level.tests/fixtures/keyword_lint_baseline.json: theeconomy/gdp … 'economic growth'entry no longer fires (the growth record now says it) and is dropped per the ratchet.Gate (Docker,
smartbrain_3000:dev)check: 8,674 records, 259 with answers, 0 invalid ·answers-check --lint: 0 problems (470 held by the baseline) ·evallookup: top-1 46/46, top-3 46/46 · pytest: 266 passed.The app's 148-row labeled locate set measured against a pack built from this branch: identical to the pinned pack, row for row, for both the app's main and its locate branch.