Feat/release invocation - #18
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
@SecondSkoll, the release-review documentation is broadly thorough, but a few copy-ready examples contain configuration details that will prevent or misdirect real usage.
- Additional feedback (no valid inline location): @SecondSkoll, the three wrapper files declare a bare
workflow_dispatch:but define their inputs only underworkflow_call. As a result, a manually dispatched wrapper cannot supplyrelease_id/release_tag(or changevalidate_only,focus, ordry_run), despite this documentation describing manual rollout. Add matchingworkflow_dispatch.inputsdeclarations or describe these wrappers as reusable-only.
| release_tag: ${{ inputs.release_tag }} | ||
| configuration_source: central | ||
| # configuration_ref must be the same reviewed commit SHA as `uses:` above. | ||
| configuration_ref: 61ed1bbd34a878f3ae270b1e4ff027cf786b730b |
There was a problem hiding this comment.
@SecondSkoll, for configuration_source: central, this SHA is resolved in the repository configured by the central alias (SecondSkoll/generic-agentic-workflows-config), not necessarily in the repository containing the reusable workflow. Requiring it to equal the uses: SHA will fail unless both repositories happen to contain the same commit; document and use an independently valid configuration-repository commit SHA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a workflow that is scoped to releases rather than issues or PRs.