Repository navigation
chore(ci): gitleaks passes the release key's public fingerprint - #40
Merged
Merged
Conversation
The security review report (#39) quotes the release key's SSH fingerprint from the reviewers' reports, and gitleaks reads it as a generic API key. It is public by design (MAINTAINERS.md, .github/allowed_signers). Since #28 a pull request can't allowlist its own findings, so this lands first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security review report in #39 quotes the release key's public SSH fingerprint (
SHA256:HqIaFq…) from the reviewers' reports, and gitleaks reads it as a generic API key. The fingerprint is public by design: it is inMAINTAINERS.mdand.github/allowed_signers. This adds it as a stopword. Since #28 a pull request can't allowlist its own findings, so this lands onmainfirst.Lead check: with this config, CI's scan command finds no leaks on #39's branch.
🤖 Generated with Claude Code