Repository navigation
chore(ci): gitleaks passes the published test-vector nonces - #36
Merged
Merged
Conversation
PR #35's tests use the nonces of the signed-request and proof test vectors in docs/reference/http-api.md, which gitleaks reads as generic API keys. They are public examples. Adding them as stopwords, next to the "0123456789" placeholder rule, lets every test that quotes them pass without one allowlist line per file. Since #28 a pull request can't allowlist its own findings, so this lands on main first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
HackTuah
pushed a commit
that referenced
this pull request
Oct 7, 2026
… task The engine swaps in 8 ms slices, so on a busy machine a test's last block could swap a slice after load() returned, and the assertion saw the old text: "a tabindex=0 chip…" failed CI this way on #36, a PR that only changes .gitleaks.toml. load() now waits until the page has had no change for 50 ms (at most 3 s). Under heavy load (128 parallel runs of the file), failing runs went from 30 to 8; the 8 left are one older test whose proper-noun check has a time limit of its own (recorded on SCR-764). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #35's
secretscheck flags three lines in its tests as generic API keys. They are the nonces of the signed-request and proof test vectors published indocs/reference/http-api.md, not secrets. This adds those two exact values as gitleaks stopwords, next to the existing0123456789placeholder rule. Since #28, a pull request can't allowlist its own findings, so the change lands onmainfirst.Lead check: with this config, the CI scan command (HEAD history, base settings, tree copies removed,
--ignore-gitleaks-allow) finds no leaks on #35's branch, and none on this one.🤖 Generated with Claude Code