Repository navigation
chore(ci): let gitleaks pass the proof route's public test nonce - #33
Merged
Merged
Conversation
PR #31's extension test uses the nonce from the proof route's documented test vector, which gitleaks reads as a generic API key. Since #28, a pull request can't allowlist its own findings, so the entry lands on main first, as that change intends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #31's
secretscheck flagstest/bg/background.test.mjs:1122as a generic API key. The value is the nonce from thePOST /api/v1/prooftest vector published indocs/reference/http-api.md, not a secret. Since #28, the scan reads.gitleaksignorefrom the base commit, so a pull request can't allowlist its own finding. The entry goes tomainhere first. The same commit is in #32, so this one line unblocks both.🤖 Generated with Claude Code