Repository navigation
test(extension): the never-swap test no longer depends on the date - #30
Merged
Merged
Conversation
The language a word shows in is drawn per page per day (slice 18), and "thanks" has three. The test expected Russian, which the draw picks on some days only; on 2026-10-07 (UTC) it drew Mandarin, which failed CI on every branch and the rc.1 release build (security review finding C-08). The test is about the never-swap list, so it now loads only the Russian words. Pinned to each day of October 2026, it failed on 18 days before and passes on all after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
HackTuah
pushed a commit
that referenced
this pull request
Oct 7, 2026
The language a word shows in is drawn per page per day (slice 18). Three new tests in this branch expected the Russian word for "thanks", which the draw picks on some days only; on 2026-10-07 it drew Mandarin, and CI failed. #30 fixed one such test by hand; this pins the page's clock to noon on 2026-10-06 for every test page, with time still running on, so no content test can depend on the day again. Without it, three tests fail under TZ=UTC today; with it, all pass in four time zones covering 6, 7 and 8 October. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DOM test "a word on the never-swap list stays, on every page, until it is taken off" depended on the date. The language a word shows in is drawn per page per day (slice 18); on 2026-10-07 UTC the draw picks Mandarin, so the test fails on every branch today,
mainincluded, and it failed the rc.1 release build (security review finding C-08). This one-line test change loads only the Russian words, so the outcome no longer depends on the day. Pinned to each day of October 2026, the test failed on 18 days before and passes on all after.It unblocks #28 and #29. The same change is part of the larger
fix/sec-backgroundbranch.🤖 Generated with Claude Code