Repository navigation
docs: the code review standard - #22
Merged
Merged
Conversation
docs/CODE_REVIEW.md says how a pull request is reviewed and what it needs to merge: CI's required checks first, a reviewer who isn't the author, every thread resolved, and a checklist of what must be true (spec and tests, trust boundaries, input validation, privacy inventory, dependencies, every-language and accessibility rules, size budgets, docs, DCO), plus the standard of evidence for claims. It also says plainly that the lead maintainer may still merge their own change after CI while there are few maintainers. CONTRIBUTING.md links it. This makes the OpenSSF gold criterion code_review_standards Met. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
HackTuah
pushed a commit
that referenced
this pull request
Oct 6, 2026
The secrets job checks out with fetch-depth 0, which fetches every branch, and ran gitleaks with --log-opts=--all. So a finding on one pull request's branch failed every other pull request (#22 failed on a test key in #21's branch). It now scans HEAD: the whole history of main plus the pull request's own commits, which is everything that would land. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
Silver was earned on 2026-10-06, so the gold prerequisite is Met. The page would otherwise have set it back to Unmet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ayla Croft <dev@scriptkittyos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/CODE_REVIEW.md: how a pull request is reviewed and what it needs before it merges. This is for OpenSSF goldcode_review_standards(Met with this PR).CONTRIBUTING.md now links it.
Checked
bestpractices-links --check(209 valid),check-old-name,check-base-neutral. Every path the document names exists.🤖 Generated with Claude Code