Repository navigation
Slice 027 records: changelog entry and coverage row - #87
Merged
Merged
Conversation
Written before the tag rather than after it, which is the direction test/changelog_test.exs allows: every tag needs an entry, an entry without a tag is fine. Slice 090 built that test after finding two tags with no entry at all, and this is the first slice to close under it. It should have been in the slice's own pull request. It was not, and the test caught the gap the moment the tag was considered, which is the test working. Signed-off-by: Ayla Croft <aylacroft@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog entry and coverage row for slice 027, written before the tag.
test/changelog_test.exs(slice 090) requires everyslice/*tag to have a changelog entry, and allows an entry with no tag yet. This is the first slice to close under that rule, and it caught that the entry was missing from the slice's own PR.🤖 Generated with Claude Code