Repository navigation
Bring the standards register's gold row up to what the tree holds - #80
Merged
Merged
Conversation
The row was written before the criteria it lists were closed, and an edit that should have landed with them missed the branch it belonged on, so the register has been claiming 30% and four open items that are no longer open. Met in the tree now: require_2FA, copyright_per_file and license_per_file, code_review_standards, small_tasks, security_review, and build_reproducible for the release. Not applicable: test_branch_coverage80, because the criterion is conditional on a FLOSS tool existing for the language and cover:analyse/3 raises function_clause for branch. Still outstanding and still named: bus_factor, contributors_unassociated and two_person_review need people other than the author in the git history and cannot be bought with code; test_statement_coverage90 needs 90% against 80.31%; dynamic_analysis needs a tool the project does not run; secure_2FA depends on which second factor the maintainers use. Signed-off-by: Ayla Croft <aylacroft@proton.me>
HackTuah
force-pushed
the
docs/register-gold-row
branch
from
September 23, 2026 21:56
c59cada to
a551482
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gold row was written before the criteria it lists were closed, and the edit that should have landed with them went to the wrong branch and failed its assertion — so the register has been claiming 30% and four open items that are no longer open. A register that overstates what is outstanding is wrong in the same way as one that overstates what is met.
Met in the tree now:
require_2FA;copyright_per_fileandlicense_per_file(held bytest/spdx_headers_test.exs);code_review_standards;small_tasks;security_review; andbuild_reproduciblefor the release, re-runnable with./scripts/check_reproducible.sh.Not applicable:
test_branch_coverage80— the criterion is conditional on a FLOSS tool existing for the language, andcover:analyse/3raisesfunction_clauseforbranch, which is what every Elixir coverage tool wraps.Still outstanding, still named:
bus_factor,contributors_unassociatedandtwo_person_reviewneed people other than the author in the git history and cannot be bought with code;test_statement_coverage90needs 90% against 80.31%;dynamic_analysisneeds a tool the project does not run;secure_2FAdepends on which second factor the maintainers use.mix gateexit 0; 580 passed, 18 excluded.