Repository navigation
feat(s060): complete slice 060 (MCP client) - #54
Merged
Merged
Conversation
Signed-off-by: Ayla Croft <aylacroft@proton.me>
… bridge, servers; AC1 and AC6 green The registry takes a dynamic tool as a module plus a spec so one bridge module serves every MCP tool; the context carries the tool name. The stdio child keeps the process basics and the row's env refs and nothing else of this VM's environment. The servers under test are beam_mcp's own transports over a test catalog (stdio in a child VM, HTTP behind Bandit) and a double for the multi-round-trip wire the core refuses by design. Signed-off-by: Ayla Croft <aylacroft@proton.me>
…al receipt, the multi-round-trip loop through a Session Signed-off-by: Ayla Croft <aylacroft@proton.me>
…llow list; no risk override Signed-off-by: Ayla Croft <aylacroft@proton.me>
Signed-off-by: Ayla Croft <aylacroft@proton.me>
…tion answered from the permissions page Signed-off-by: Ayla Croft <aylacroft@proton.me>
Signed-off-by: Ayla Croft <aylacroft@proton.me>
…; the dev script that drives it Signed-off-by: Ayla Croft <aylacroft@proton.me>
…functions (credo) Signed-off-by: Ayla Croft <aylacroft@proton.me>
Signed-off-by: Ayla Croft <aylacroft@proton.me>
Signed-off-by: Ayla Croft <aylacroft@proton.me>
Signed-off-by: Ayla Croft <aylacroft@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 060: Trinity's thin MCP client over beam_mcp 0.8.0's public functions (ADR-0007 decision 7). One supervised client per mcp_servers row; stdio (a child on a Port with an allow-listed environment) and Streamable HTTP (one POST per request with the revision's headers); server/discover first, initialize at 2025-11-25 as the fallback; every listed tool a dynamic tool mcp:: through one bridge module and a registry spec; every result untrusted; the multi-round-trip loop on 021's approvals (a server's input_required is an approval carrying its request, the answer rides the decision, the retry echoes requestState byte-for-byte). The /mcp page and the input-request card.
AC1 to AC4, AC6, AC7 by test; AC5 (Tasks) deferred at G1 under 059's approved finding 4; AC8 done once against the public 2026-07-28 playground server (GIF in proof/). Gate green, 478 passed; coverage 80.32 (from 80.54). Deviations and five findings in NOTES.md.
Signed-off-by: Ayla Croft aylacroft@proton.me