Repository navigation
docs: the approval flow as a demo, now that it reliably completes - #103
Merged
Merged
Conversation
Replaces the approval card still with a 48-frame capture of the whole turn: the request typed, the model asking to run a write-risk tool, Trinity stopping with the exact arguments, the WRITE badge and four choices, and the call running only after Allow once is clicked. It ends on the tool result and the answer. 122KB, so it costs the page nothing. This is the asset that was held back twice. The first attempt filmed a turn that never completed, because the demo script left Trinity.Repo.Receipts on the test sandbox pool and every receipt write queued behind a long-lived connection holder; since a decision is receipted before it is dispatched, the tool task stopped after the approval existed and the card was painted but before it could answer the session. Slice 126 fixed the script and slice 125 fixed the redaction filter that was dying in the same runs. The fix is visible in the capture: the status pill reads "waiting for approval", where before it sat on "running tools" until the call timed out. The approval card still is removed rather than kept beside it. The GIF shows the same screen and more, and two images was already the budget. Signed-off-by: Ayla Croft <aylacroft@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 48-frame capture of the whole turn, replacing the approval card still at the top of the README: the request typed, the model asking to run a write-risk tool, Trinity stopping with the exact arguments it will pass, the
WRITEbadge and four choices, and the call running only after "Allow once" is clicked. It ends on the tool result and the answer.122KB, so it costs the page nothing.
This is the asset that was held back twice
The first attempt filmed a turn that never completed. The cause was
scripts/dev_demo_approval.shleavingTrinity.Repo.Receiptson the test sandbox pool: outside the suite that pool blocks, and because a decision is receipted before it is dispatched, the tool task stopped after the approval row existed and the card was painted but before it could answer the Session. Slice 126 fixed the script. Slice 125 fixed the redaction filter that was dying in the same runs.The fix is visible in the capture itself. The status pill reads
waiting for approval, where before it sat onrunning toolsuntil the call timed out and reported an error for something the owner had allowed.Why the still is removed rather than kept
The GIF shows that same screen and more, and two images was already the budget. What remains is the GIF and the receipts page for the same call, which is the whole argument: it asks before it acts, and the answer is evidence afterwards.
scripts/dev_demo_approval.shregenerates both, so they are reproducible rather than pictures nobody can make again.