Skip to content

fix: update outdated clone URL in CONTRIBUTING.md #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
watney1024 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Draft

fix: update outdated clone URL in CONTRIBUTING.md #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b16370
fix: update outdated clone URL in CONTRIBUTING.md
watney1024 Jul 26, 2026
7f89436
fix: emit_i32_and uses i1 instead of i32 in LLVM IR output
watney1024 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ are very welcome.
## Quick Start

```bash
git clone https://github.com/kinsomwang/ScratchV
git clone https://github.com/ScratchV-Compiler/ScratchV
cd ScratchV
pip install -e . # install in editable mode
pip install tinyfive # optional: assembly verification
Expand Down
2 changes: 1 addition & 1 deletion scratchv/standalone/onnx_to_llvm_standalone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ def emit_i32_icmp(self, predicate: str, lhs: str, rhs: str) -> str:

def emit_i32_and(self, lhs: str, rhs: str) -> str:
r = self.fresh("iand")
self._p(f" {r} = and i1 {lhs}, {rhs}")
self._p(f" {r} = and i32 {lhs}, {rhs}")
return r

# -- control flow ------------------------------------------------------
Expand Down
Loading