[CLI] Display long available device id - #13338
Conversation
FirelightFlagboy
left a comment
There was a problem hiding this comment.
The goal of the refactor was also to normalize how to show things to user.
Better to choose one version only, I would prefer the long format
|
From what I understand of the issue, the goal was to just display the long id during the confirmation process. It may be worth having a look if there are other places where the id is displayed for confirmation. I'd rather keep the short id, at least in the list that is shown when a device id is missing from a command. What to do with the real list available device is up to discussion. Or we could get rid of the short ids completely ? Or never show them but still be able to accept them as input (or there maybe there is some auto completion trick that can be done ?) |
|
For displaying short id, you cannot use an hardcoded value because it may not display enough information to discriminate one device from another. You need the length of the id to be adapted accordingly following the global context. Lines 54 to 61 in 653e190 |
1cb14ae to
e097a2d
Compare
e097a2d to
b92c70b
Compare
So forget local device can display the full ID.
Fix #8602