Skip to content

Issue #19: Release GIL when executing ndiCommand. - #20

Open
MattClarkson wants to merge 3 commits into
SciKit-Surgery:2github-actionsfrom
MattClarkson:19-reduce-GIL-locking
Open

Issue #19: Release GIL when executing ndiCommand.#20
MattClarkson wants to merge 3 commits into
SciKit-Surgery:2github-actionsfrom
MattClarkson:19-reduce-GIL-locking

Conversation

@MattClarkson

Copy link
Copy Markdown

Release GIL around ndiCommand - not tested yet.
Will test, when back in the lab.

@MattClarkson
MattClarkson requested a review from thompson318 July 31, 2026 20:14

@thompson318 thompson318 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Will enable multithreading and I don't think introduces any new bugs in ndicapi. A couple of things to think about.

  1. This will allow the calling application to make multiple simultaneous calls to the same tracker, which could cause problems. This is probably best managed by the calling application, so add a note to the function description.
  2. I'd like to avoid our version of ndicapi diverging from https://github.com/PlusToolkit/ndicapi. The idea is that 2github-actions just adds the infrastructure for building wheels and publishing to pypi to PlusToolKit's master branch. So I suggest adding some documentation then creating a pull request to https://github.com/PlusToolkit/ndicapi/tree/master. They're generally good at responding and may also pick up on any other issues with the PR. If that works then I will update our version and rebuild.

@MattClarkson
MattClarkson force-pushed the 19-reduce-GIL-locking branch from 3461a8b to c0ba20c Compare August 18, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants