Repository navigation
0.11.0: alarms in the history, address book import and export - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.11.0.
Alarms in the history
The RustDesk app reports alarms to
/api/audit/alarm. RDAPI has stored them since the start but never showed them. A new tab History → Alarms (/history/alarms) lists them like the file transfers: newest first, 20 per page, filterable by device. Admins see all devices, regular users only their own.AlarmAuditType(0, 1, 2, 6, 7, 8, 9, 10); unknown codes show as "Other alarm (n)".infois parsed defensively (broken JSON, wrong types); shown: address, ID and name of the other side, and themessageof a session scope violation.Address book import and export
On the address book page, a new panel Import and export:
GET /address-book/export?book=…&format=json|csv) for everyone who can see the book. JSON carries the tags with their colours; CSV has the columnsid, alias, note, tags, hostname, platform, username(tags joined by;), starts with a UTF-8 BOM for spreadsheets, and prefixes cells starting with= + - @to prevent formula injection.POST /address-book/import) for books the user may change. Accepts an RDAPI JSON export or a CSV table with anidcolumn (comma or semicolon separated). New IDs are added, existing entries get the fields from the file and keep their tags, nothing is deleted. Field lengths are capped like in the web form; at most 5,000 entries; files up to just under the 2 MB request limit.hash,password) are never exported and never taken from an import file; existing ones stay untouched.ab_exported,ab_importedwith counts).Maintenance
httpx2instead ofhttpx(Starlette's test client deprecatedhttpx); the deprecation warning is gone.requires-python >= 3.14); the formatter switched fourexcept (A, B):to the PEP 758 form.render()accepts an explicit message, used for the import result.Tested
pytest(158 passed, no warnings),ruff check,ruff format --check.Not tested: the real RustDesk app sending a real alarm, and sign-in through a real OIDC provider.