Repository navigation
Conversation
main is deployed as-is by GitHub Pages and piped into bash, so check every pull request before it can be merged: - tests/lint.sh: bash -n and ShellCheck (errors only) on every script, manifest consistency, a single fallback URL matching install.sh, no download outside CONFLOOSE_BASE, and every downloaded file present. - tests/smoke.sh: serves the repo locally, checks the menu, then applies and undoes each confloose through install.sh in a throwaway HOME with the X11/i3 tools stubbed, and requires the HOME to be restored exactly. The three daemon confloose are skipped. The Contributing section now lists both checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis deployed as-is by GitHub Pages and piped intobash, so every pull request is now checked before it can be merged. Two jobs,lintandsmoke, run on each pull request and on pushes tomain. The Contributing section of the README lists both scripts as a step before opening a PR.Checks
lint(tests/lint.sh)bash -nand ShellCheck (bash dialect, errors only) on every script, including extension-less ones likefake-gcc/gccconfloose.shandantidote.sh, each folder is listed in the manifest, no duplicatesinstall.shdefaultCONFLOOSE_BASEinconfloose/smoke(tests/smoke.sh)install.shin a throwaway HOME, then requires that HOME to match its initial state exactly (content and file modes).bashrc, i3 config, Alacritty config, a~/.local/bin/gccshim) that antidotes must leave intacti3-msg,xrandr,xinput,setxkbmap,xkillandi3lock, so it is also safe to run locallydaemon-terminal,i3loopandtchikistart a background daemon and are skippedWorkflow
permissions: contents: read,pull_requesttrigger (fork PRs get a read-only token and no secrets)actions/checkoutpinned by commit SHA (v7.0.1), credentials not persistedVerification
lint.shon currentmain, ShellCheck 0.9.0 (runner version) and 0.11.0smoke.shon currentmainfake-git)alacritty-color)sleep)fake-git)After merge
lintandsmokecan be added as required status checks in theMainruleset; they become selectable once the workflow has run.