Skip to content

tapgarden: caller-defined genesis anchor PSBTs (issue #721, slim) - #9

Draft
SadiqJaf wants to merge 13 commits into
mainfrom
ta/721-slim
Draft

SadiqJaf wants to merge 13 commits into
mainfrom
ta/721-slim

Conversation

@SadiqJaf

@SadiqJaf SadiqJaf commented Oct 7, 2026 •

Copy link
Copy Markdown

Rebuild of lightninglabs/taproot-assets#721 as a minimal upstream-quality slice (replaces the exploratory fork PR #5 history without modifying that branch).

Base: This PR targets Satscryption/taproot-assets main. Sync main to upstream lightninglabs/taproot-assets 10759c4a before merge (or use a sync/upstream-10759c4a base). Implementation is rebased on upstream 10759c4a.

Included: FundBatch / PrepareBatch / FinalizeBatch for caller-funded anchor PSBTs, batch-scoped wallet leases, signed PSBT persistence in the existing minting_tx_psbt column, CLI hardening, one itest (testMintCustomAnchorPsbt), and trimmed unit coverage.

Dropped from the old fork PR: historical key repair, publish-error tokenizer matrix, MuSig2/MINT-10 itest, legacy {1} lease marker / rejected-marker alias, DB migration.

Bug fixes (with tests):

  • Register mint anchoring (and resolve PkScript from NonWitnessUtxo) before publish; no broadcast without a watchable trigger set.
  • Prepared custom-anchor batches (Committed after PrepareBatch) are not cancellable.
  • Final validation requires SIGHASH_ALL / SIGHASH_DEFAULT on finalized inputs.
  • Definitive mempool policy rejects revert to import-pending (cancellable) without the full tokenizer.
  • ensureOutputPsbtWritable rejects non-regular paths and probes CreateTemp in the parent for existing files.

CI notes: Release notes entry links to upstream PR #2238. Fork check-release-notes greps for lightninglabs/taproot-assets/pull/<fork PR #> (here 9), so that job may fail on this fork until the branch lands upstream as lightninglabs#2238.

Verified locally: go build -tags="dev monitoring nolog" ./..., make unit for tapgarden, lndservices, cmd/commands, rpcserver.

Deferred: Full make itest icase=mint_custom_anchor_psbt (needs btcd/lnd harness); raw gRPC FundBatch change-index footgun test; optional interface_compat_test trim.

Open in Web Open in Cursor 

@cursor
cursor Bot force-pushed the ta/721-slim branch 2 times, most recently from 02a52d0 to 4baa2b0 Compare October 7, 2026 07:08
cursoragent and others added 13 commits October 7, 2026 10:38
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Co-authored-by: Sadiq Jaffer <SadiqJaf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants