Repository navigation
Add SAST scanner endpoint #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ymuft
wants to merge
5
commits into
SasanLabs:main
Choose a base branch
from
ymuft:feat/sast-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7474422
Add SAST scanner ground-truth endpoint
ymuft 035334d
Register SAST scanner route
ymuft a2d794c
Validate SAST scanner responses
ymuft 51a783f
docs: document SAST scanner methods
ymuft de69240
docs: document Bootstrap route registration
ymuft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| <?php | ||
| declare(strict_types=1); | ||
|
|
||
| namespace scanner; | ||
|
|
||
| use fileupload\FileUpload; | ||
| use magichash\MagicHash; | ||
| use nosqlinjection\NoSQLInjection; | ||
| use ReflectionMethod; | ||
|
|
||
| class SASTScanner | ||
| { | ||
| private const CATALOG = [ | ||
| [ | ||
| "class" => FileUpload::class, | ||
| "filePath" => "src/FileUploadVulnerability/FileUpload.php", | ||
| "methods" => [ | ||
| "level1", | ||
| "level2", | ||
| "level3", | ||
| "level4", | ||
| "level5", | ||
| "level6", | ||
| "level7", | ||
| "level8", | ||
| "level9", | ||
| "level10", | ||
| "level11", | ||
| ], | ||
| "cwe" => "CWE-434", | ||
| "type" => "Unrestricted File Upload", | ||
| ], | ||
| [ | ||
| "class" => MagicHash::class, | ||
| "filePath" => "src/MagicHashVulnerability/MagicHash.php", | ||
| "methods" => ["level1", "level2"], | ||
| "cwe" => "CWE-704", | ||
| "type" => "Magic Hash Exploitation", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sast has line number as wel. please follow the format mentioned at https://github.com/SasanLabs/VulnerableApp/blob/master/src/main/resources/scanner/sast/expectedIssues.csv |
||
| ], | ||
| [ | ||
| "class" => NoSQLInjection::class, | ||
| "filePath" => "src/NoSQLInjectionVulnerability/NoSQLInjection.php", | ||
| "methods" => ["level1", "level2", "level3"], | ||
| "cwe" => "CWE-943", | ||
| "type" => "MongoDB NoSQL Injection", | ||
| ], | ||
| [ | ||
| "class" => NoSQLInjection::class, | ||
| "filePath" => "src/NoSQLInjectionVulnerability/NoSQLInjection.php", | ||
| "methods" => ["level4"], | ||
| "cwe" => "CWE-256", | ||
| "type" => "Insecure Credential Storage", | ||
| ], | ||
| ]; | ||
|
|
||
| /** | ||
| * Builds the SAST ground-truth rows for all cataloged vulnerable methods. | ||
| * | ||
| * @return array<int, array{cwe:string, filePath:string, line:int, numberOfSources:int, type:string}> | ||
| */ | ||
| private function buildScannerRows(): array | ||
| { | ||
| $rows = []; | ||
|
|
||
| foreach (self::CATALOG as $entry) { | ||
| foreach ($entry["methods"] as $methodName) { | ||
| $method = new ReflectionMethod($entry["class"], $methodName); | ||
| $rows[] = [ | ||
| "cwe" => $entry["cwe"], | ||
| "filePath" => $entry["filePath"], | ||
| "line" => (int) $method->getStartLine(), | ||
| "numberOfSources" => 1, | ||
| "type" => $entry["type"], | ||
| ]; | ||
| } | ||
| } | ||
|
|
||
| return $rows; | ||
| } | ||
|
|
||
| /** | ||
| * Emits the SAST ground-truth catalog as JSON for facade aggregation. | ||
| */ | ||
| function sast(): void | ||
| { | ||
| header("Content-type: application/json"); | ||
| echo json_encode($this->buildScannerRows(), JSON_UNESCAPED_SLASHES); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better if we have a csv file listing all the sast vulnerabilities and sast endpoint exposes it as Json file. you can look at https://github.com/SasanLabs/VulnerableApp/blob/master/src/main/resources/scanner/sast/expectedIssues.csv for more information.