Skip to content

Danish locale, Captial letters missing & nil value - #1

Merged
Github-Samuel merged 3 commits into
Samuels-Development:mainfrom
HeinoDev:main
Sep 12, 2026
Merged

Github-Samuel merged 3 commits into
Samuels-Development:mainfrom
HeinoDev:main

Conversation

@HeinoDev

@HeinoDev HeinoDev commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@HeinoDev HeinoDev changed the title Danish locale Danish locale, Captial letters missing & nil value Aug 1, 2026
@Github-Samuel

Copy link
Copy Markdown
Member

Automated review: ✅ looks good

Adds a complete Danish locale (matches en.json's key set 1:1), capitalizes two previously lowercase English error strings, and fixes onlineIds() in give.lua to skip non-numeric GetPlayers() entries instead of leaving nil holes in the returned array. All changes are small, in-scope for the reported bug, and verified against their only call sites (nearbyIds/recipients, which rely on ipairs/#ids and would break on holes). No security, perf, or framework-path concerns.

93% likely to work as merged - judged by reading, no in-game test needed: All three changes are small and fully traced: da.json has the exact same 26 keys as en.json and locale loading already globs locales/*.json with per-key fallback to en, so no registration is needed; the en.json capitalization change only touches those two literal strings with no other consumers found; onlineIds' nil-filtering fix uses the standard append idiom and its only callers iterate via ipairs/#ids, so compacting the array is correct and fixes the real bug (holes from unparsable player ids)."

  • 💬 nit README.md:51 - Doc example still shows the old lowercase '(no room)' string; harmless (just prose), but now slightly out of sync with the actual locale value 'No room'. Not blocking.

Second-pass review by bug-fixer. A human still decides whether to merge.

@Github-Samuel
Github-Samuel merged commit 27e7b22 into Samuels-Development:main Sep 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants