Danish locale, Captial letters missing & nil value - #1
Conversation
Automated review: ✅ looks goodAdds a complete Danish locale (matches en.json's key set 1:1), capitalizes two previously lowercase English error strings, and fixes onlineIds() in give.lua to skip non-numeric GetPlayers() entries instead of leaving nil holes in the returned array. All changes are small, in-scope for the reported bug, and verified against their only call sites (nearbyIds/recipients, which rely on ipairs/#ids and would break on holes). No security, perf, or framework-path concerns. 93% likely to work as merged - judged by reading, no in-game test needed: All three changes are small and fully traced: da.json has the exact same 26 keys as en.json and locale loading already globs locales/*.json with per-key fallback to en, so no registration is needed; the en.json capitalization change only touches those two literal strings with no other consumers found; onlineIds' nil-filtering fix uses the standard append idiom and its only callers iterate via ipairs/#ids, so compacting the array is correct and fixes the real bug (holes from unparsable player ids)."
Second-pass review by bug-fixer. A human still decides whether to merge. |
No description provided.