Repository navigation
Fix HistoryFlowTest on the 1st of a month - #178
Merged
Merged
Conversation
The calendar keeps its month between picks, but the helper always navigated back from the current month. On the 1st, yesterday and three days ago fall in the previous month, so the second pick went two months back and could not find its day. Track the month on screen instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
mainfails (run 41294069688):HistoryFlowTest.pickingADayWithoutAVisit_namesItRelativeToTodayis the only failing test of 969. It is date-dependent, so it started failing on Nov 1.Cause
pickDayInMonthCalendaralways clicked Previous(current month - target month)times, but the calendar keeps the month it shows. On the 1st, "yesterday" and "3 days ago" are in the previous month, so the second pick went back one more month and its day was not there.Fix
Track the month on screen (
shownMonth) and navigate relative to it. Test-only change.Verification
HistoryFlowTestpasses locally (all 23 tests), run on Nov 1.🤖 Generated with Claude Code