Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
一个小小的测试bug修复：test里面并行线程数的计算方法和实际代码中的不一致 导致在2-3线程的时候 这个测试会失败
解决办法：把线程数的计算方法抽出来 作为一个单独的函数，测试里面也调用这个函数就行了
The completion-order test only skipped on single-core systems, while the parser worker pool uses half of the available parallelism. On 2-3 core builders this leaves one worker, so completion order cannot differ from input order.
Factor the worker-count calculation into a helper and use the same calculation in the test guard.