fix: use global fortran lock instead of per-library#103
Merged
Conversation
We are sharing Fortran SAVE state and other global things and using a shared library too, so we need to raise the lock up to the top-level and not try to optimize it for individual libraries. There are likely few people who need the per-library performance benefit.
cea784b to
6fc8c3b
Compare
Member
Author
|
Note the real impactful change here was zero-initializing the arrays entering Fortran, it seems like that might not be safe in the Python <-> Fortran bridge layer and some unitialized values get used somewhere only occasionally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are sharing Fortran SAVE state and other global things and using a shared library too, so we need to raise the lock up to the top-level and not try to optimize it for individual libraries. There are likely few people who need the per-library performance benefit.