Skip to content

fix(SWRDataLabDark): Stray dam polygons #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awesomephant merged 2 commits into from
May 28, 2026
Merged

fix(SWRDataLabDark): Stray dam polygons #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f4016c
Implement fix
awesomephant May 28, 2026
904032e
Pin node version, bump actions/setup-node from 6.0.3 to 6.4.0
awesomephant May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ jobs:
timeout-minutes: 10
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: lts/*
node-version: 24
- run: npm ci --workspace=components --include=dev
- run: npm run sync --workspace=components
- run: npm ci --workspace=mock-sveltekit
Expand Down
103 changes: 62 additions & 41 deletions components/src/maplibre/MapStyle/SWRDataLabDark.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,144 +80,165 @@
</div>
</DesignTokens>
</Story>
<Story asChild name="fix/251">

<Story asChild name="Bodensee z9">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map
showDebug
style={SWRDataLabDark()}
initialLocation={{
lng: 10.005803094126804,
lat: 53.54086081679415,
zoom: 14.215291362684706,
pitch: 0
}}
>
<Map showDebug style={SWRDataLabDark()} initialLocation={locations.bodensee}>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>
<Story asChild name="fix/200">

<Story asChild name="Frankfurt z11">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map
showDebug
style={SWRDataLabDark()}
initialLocation={{
lng: 8.96467732459405,
lat: 48.93101909877453,
zoom: 13.507311695217375,
pitch: 0
}}
style={SWRDataLabDark({ enableBuildingExtrusions: true })}
initialLocation={locations.frankfurt}
>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>
<Story asChild name="fix/173">
<Story asChild name="Berlin z12">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map showDebug style={SWRDataLabDark()} initialLocation={{ ...locations.berlin, zoom: 11 }}>
<Map showDebug style={SWRDataLabDark()} initialLocation={locations.berlin}>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>

<Story asChild name="Bodensee z9">
<Story asChild name="Stuttgart z13">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map showDebug style={SWRDataLabDark()} initialLocation={locations.bodensee}>
<Map showDebug style={SWRDataLabDark()} initialLocation={locations.stugge}>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>

<Story asChild name="Frankfurt z11">
<Story asChild name="Baden-Baden z15">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map
showDebug
style={SWRDataLabDark({ enableBuildingExtrusions: true })}
initialLocation={locations.frankfurt}
style={SWRDataLabDark({ enableBuildingExtrusions: false, enableHillshade: true })}
initialLocation={locations.badenBaden}
>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>
<Story asChild name="Berlin z12">
<Story asChild name="Motorway Interchange z14">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map showDebug style={SWRDataLabDark()} initialLocation={locations.berlin}>
<Map showDebug style={SWRDataLabDark()} initialLocation={locations.motorwayz14}>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>
<Story asChild name="Stuttgart z13">
<Story asChild name="Building Extrusions">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map showDebug style={SWRDataLabDark()} initialLocation={locations.stugge}>
<Map
showDebug
style={SWRDataLabDark({ enableBuildingExtrusions: true })}
maxZoom={20}
initialLocation={locations.buildings}
>
<GeocoderControl languages="de" service="maptiler" key="V32kPHZjMa0Mkn6YvSzA" />
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>
<Story asChild name="Baden-Baden z15">
<Story asChild name="fix/251">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map
showDebug
style={SWRDataLabDark({ enableBuildingExtrusions: false, enableHillshade: true })}
initialLocation={locations.badenBaden}
style={SWRDataLabDark()}
initialLocation={{
lng: 10.005803094126804,
lat: 53.54086081679415,
zoom: 14.215291362684706,
pitch: 0
}}
>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>
<Story asChild name="Motorway Interchange z14">
<Story asChild name="fix/200">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map showDebug style={SWRDataLabDark()} initialLocation={locations.motorwayz14}>
<Map
showDebug
style={SWRDataLabDark()}
initialLocation={{
lng: 8.96467732459405,
lat: 48.93101909877453,
zoom: 13.507311695217375,
pitch: 0
}}
>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>
<Story asChild name="Building Extrusions">
<Story asChild name="fix/173">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map showDebug style={SWRDataLabDark()} initialLocation={{ ...locations.berlin, zoom: 11 }}>
<AttributionControl position="bottom-left" />
</Map>
</div>
</div>
</DesignTokens>
</Story>
<Story asChild name="fix/391">
<DesignTokens theme="dark">
<div class="grid">
<div class="container">
<Map
showDebug
style={SWRDataLabDark({ enableBuildingExtrusions: true })}
style={SWRDataLabDark()}
maxZoom={20}
initialLocation={locations.buildings}
initialLocation={{
lng: 7.162106315605001,
lat: 50.56038132182053,
zoom: 13.440582725369412,
pitch: 0
}}
>
<GeocoderControl languages="de" service="maptiler" key="V32kPHZjMa0Mkn6YvSzA" />
<AttributionControl position="bottom-left" />
</Map>
</div>
Expand Down
4 changes: 2 additions & 2 deletions components/src/maplibre/MapStyle/components/Landuse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ export default function makeLanduse(tokens): any {
'source-layer': 'dam_polygons',
filter: ['==', 'kind', 'dam'],
paint: {
'fill-color': 'hsl(33,0%,95%)',
'fill-color': tokens.sand,
'fill-opacity': {
stops: [
[12, 0],
Expand All @@ -328,7 +328,7 @@ export default function makeLanduse(tokens): any {
'source-layer': 'dam_lines',
filter: ['==', 'kind', 'dam'],
paint: {
'line-color': 'hsl(205,0%,85%)'
'line-color': tokens.sand
},
layout: {
'line-cap': 'round',
Expand Down
Loading