Skip to content

ChartFooter: Add showLogo prop #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awesomephant merged 1 commit into from
Sep 1, 2025
Merged

ChartFooter: Add showLogo prop #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions components/src/ChartFooter/ChartFooter.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script context="module">
import { defineMeta } from '@storybook/addon-svelte-csf';
import DesignTokens from '../DesignTokens/DesignTokens.svelte';
import { expect } from 'storybook/test';

import ChartFooter from './ChartFooter.svelte';
import Middot from '../Middot/Middot.svelte';
Expand Down Expand Up @@ -33,6 +34,26 @@
</DesignTokens>
</Story>

<Story
name="One-up Centered, no Logo"
asChild
play={async ({ step }) => {
await step('Does not render the logo', async () => {
const el = document.querySelector('.container > svg');
expect(el).toBeFalsy();
});
}}
>
<DesignTokens>
<ChartFooter layout="one-up" align="center" showLogo={false}>
Daten: <a href="#1">Zensus 2022</a>
(Durchschnittsmieten und Einwohnerzahlen),
<a href="#1">OpenStreetMap</a> (Kartenmaterial) <Middot /> In unserer Darstellung wurde das Zensusgitter
auf bewohnte Gebiete begrenzt.
</ChartFooter>
</DesignTokens>
</Story>

<Story name="Two-up" asChild>
<DesignTokens>
<ChartFooter layout="two-up">
Expand Down
7 changes: 5 additions & 2 deletions components/src/ChartFooter/ChartFooter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@
interface ChartFooterProps {
layout?: 'one-up' | 'two-up';
align?: 'left' | 'center';
showLogo?: boolean;
children?: Snippet;
}

let { layout = 'one-up', align = 'left', children }: ChartFooterProps = $props();
let { layout = 'one-up', align = 'left', showLogo = true, children }: ChartFooterProps = $props();
</script>

<footer class={`container ${layout} align-${align}`}>
Expand All @@ -18,7 +19,9 @@
{@render children()}
</Note>
{/if}
<Logotype />
{#if showLogo}
<Logotype />
{/if}
</footer>

<style lang="scss">
Expand Down