Support Databricks query tags in session properties#5794
Open
WhammyLeaf wants to merge 1 commit into
Open
Conversation
ad8c237 to
d9881ce
Compare
Author
|
Will fix the failing style tests. |
Signed-off-by: Christian Troelsen <christian.troelsen@tryg.dk>
d9881ce to
17b3af7
Compare
Author
|
@izeigerman Perhaps you can have a look at this 😄 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Databricks SQL connector supports per-statement
query_tags, but SQLMesh did not previously pass model/session-levelsession_properties.query_tagsthrough to the connector. This change stores validated query tags for the active adapter session and forwards them to Databricks SQL connector executions.Query tags are only applied on the Databricks SQL connector path. They are not passed when execution is routed through Spark session / Databricks Connect paths, since those cursors do not support the
query_tagsargument.ISSUE: #5795
Test Plan
query_tagsNULLquery tag valuessession_properties.query_tagsCursor.execute(..., query_tags=...).