Repository navigation
Refactor/io and initial state - #72
xiaoxuan-yu merged 5 commits into
Conversation
* fix: address release readiness issues * chore: remove stale release codename * fix: preserve Windows release version ordering * test: use relative license path in Windows installer fixture --------- Co-authored-by: Xiaoxuan Yu <apple578799@outlook.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex There are still many header files included directly in main.cpp. Would it be better to consolidate them into main.h? Also, please continue with the review. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This pull request introduces a new modular and robust initial state builder for the simulation core, improves restart output handling, and updates documentation for clarity. The most significant changes are the addition of the
InitialStateBuilderclass, a refactor of the HDF5 restart output interface, and documentation improvements.Core Simulation Initialization
InitialStateBuilderclass (initial_state.h,initial_state.cpp), which modularizes and enforces the correct order of simulation initialization steps, making the process more robust and maintainable. This builder covers loading the base state, initializing dynamics, building constraints and velocities, restoring protocol state, building coordinate derivatives, distributing state, and finalizing the run range. [1] [2]MD_core.h).Restart Output Refactor
trajectory_outputto take a singleRestartOutputStatestruct, simplifying the function signature and improving maintainability. Added validation for coordinate dimensions and improved error handling. [1] [2]Documentation Updates
README.mdfiles to guide users to the new getting started and input file reference documents, improving onboarding and usability. [1] [2]Build and Versioning
windows-installer-version.yml) to automate version checks and installer metadata validation for Windows builds.control.cppby removing the codename from theSPONGE_VERSIONmacro.Minor Fixes
getchar()call after an error message ingeneralized_Born.cppto prevent unnecessary pauses on error exit.