Skip to content

Refactor/io and initial state - #72

Merged
xiaoxuan-yu merged 5 commits into
SPONGEMM:lab/sidereus-aifrom
xiaoxuan-yu:refactor/io-and-initial-state
Sep 17, 2026
Merged

xiaoxuan-yu merged 5 commits into
SPONGEMM:lab/sidereus-aifrom
xiaoxuan-yu:refactor/io-and-initial-state

Conversation

@xiaoxuan-yu

Copy link
Copy Markdown
Contributor

This pull request introduces a new modular and robust initial state builder for the simulation core, improves restart output handling, and updates documentation for clarity. The most significant changes are the addition of the InitialStateBuilder class, a refactor of the HDF5 restart output interface, and documentation improvements.

Core Simulation Initialization

  • Introduced the InitialStateBuilder class (initial_state.h, initial_state.cpp), which modularizes and enforces the correct order of simulation initialization steps, making the process more robust and maintainable. This builder covers loading the base state, initializing dynamics, building constraints and velocities, restoring protocol state, building coordinate derivatives, distributing state, and finalizing the run range. [1] [2]
  • Added necessary includes to support the new builder and related IO functionality (MD_core.h).

Restart Output Refactor

  • Refactored the HDF5 restart file export interface in trajectory_output to take a single RestartOutputState struct, simplifying the function signature and improving maintainability. Added validation for coordinate dimensions and improved error handling. [1] [2]

Documentation Updates

  • Updated both Chinese and English README.md files to guide users to the new getting started and input file reference documents, improving onboarding and usability. [1] [2]

Build and Versioning

  • Added a new GitHub Actions workflow (windows-installer-version.yml) to automate version checks and installer metadata validation for Windows builds.
  • Cleaned up the version string in control.cpp by removing the codename from the SPONGE_VERSION macro.

Minor Fixes

  • Removed a blocking getchar() call after an error message in generalized_Born.cpp to prevent unnecessary pauses on error exit.

yuhaosimba and others added 4 commits September 12, 2026 10:55
* fix: address release readiness issues

* chore: remove stale release codename

* fix: preserve Windows release version ordering

* test: use relative license path in Windows installer fixture

---------

Co-authored-by: Xiaoxuan Yu <apple578799@outlook.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T05:57:11.833365Z 7c7101f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@yuhaosimba

Copy link
Copy Markdown
Member

@codex There are still many header files included directly in main.cpp. Would it be better to consolidate them into main.h?

Also, please continue with the review.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 7c7101f91a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@xiaoxuan-yu
xiaoxuan-yu merged commit 0d5c4bf into SPONGEMM:lab/sidereus-ai Sep 17, 2026
84 of 87 checks passed
@xiaoxuan-yu
xiaoxuan-yu deleted the refactor/io-and-initial-state branch September 17, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants