Skip to content

fix: address release readiness issues - #70

Merged
xiaoxuan-yu merged 4 commits into
masterfrom
fix/release-readiness
Sep 14, 2026
Merged

xiaoxuan-yu merged 4 commits into
masterfrom
fix/release-readiness

Conversation

@yuhaosimba

Copy link
Copy Markdown
Member

Summary

  • correct virtual atom type 0 reflection to use z_v = 2h - z_source while preserving the existing input format
  • parse standard SemVer release tags in the Windows installer and separate numeric file versions from display versions
  • remove the blocking stdin read from the missing-GB-parameters error path
  • align the getting-started TOML example and documentation entry points with current behavior
  • remove the stale hard-coded release codename in a separate commit

Commits

  • 6a7f127 fix: address release readiness issues
  • 042bf8e chore: remove stale release codename

Validation

  • full dev-cpu SPONGE build
  • SPONGE -v reports only the version sourced from pixi.toml
  • all 44 configured CTest tests passed; 4 existing runtime tests were skipped by configuration
  • all 10 noPBC virtual atom validation tests passed
  • mdin schema example validation passed
  • repository format-check passed
  • git diff --check passed

Windows PowerShell and NSIS packaging will be validated by the Windows release CI job.

@yuhaosimba

Copy link
Copy Markdown
Member Author

@codex please review, if there are any problems before release version

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-14T01:35:40.003828Z 6b08ed1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 042bf8edba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packaging/windows/installer.ps1 Outdated
@xiaoxuan-yu
xiaoxuan-yu self-requested a review September 14, 2026 00:56
@xiaoxuan-yu

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 6b08ed1dbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@xiaoxuan-yu
xiaoxuan-yu merged commit 317ae56 into master Sep 14, 2026
64 of 65 checks passed
@yuhaosimba
yuhaosimba deleted the fix/release-readiness branch September 14, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants