Repository navigation
fix: address release readiness issues - #69
yuhaosimba wants to merge 2 commits into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
xiaoxuan-yu
left a comment
There was a problem hiding this comment.
Please also update the version information in SPONGE/control.cpp for release. In particular, SPONGE_CODENAME is still set to 2026-04-01 April Fools' Day.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3760de182
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| source[0][0], | ||
| source[0][1], | ||
| 2.0 * h_double - source[0][2], | ||
| 2.0 * record.parameters[0] - source[0][2], |
There was a problem hiding this comment.
Update the direct Type 0 coordinate oracle
When the medium or production A/B suite runs normal_virtual_atoms_all_types, this corrected formula places fixture atom 6 at (4, 4, 3) because its source has z=1 and h=2. However, _focused_virtual_atom_coordinate_oracle() still hard-codes that atom as (4, 4, 7) at lines 17238–17240, and the input.topology.virtual_atoms path invokes that oracle at lines 13288–13293. Consequently, both otherwise-correct runtime branches now fail _assert_virtual_atom_oracle; update the direct oracle along with this rerun oracle.
Useful? React with 👍 / 👎.
Summary
Validation
Windows PowerShell and NSIS packaging will be validated by the Windows release CI job.