Skip to content

fix: address release readiness issues - #69

Closed
yuhaosimba wants to merge 2 commits into
masterfrom
fix/release-readiness
Closed

yuhaosimba wants to merge 2 commits into
masterfrom
fix/release-readiness

Conversation

@yuhaosimba

@yuhaosimba yuhaosimba commented Sep 12, 2026 •

Copy link
Copy Markdown
Member

Summary

  • correct virtual atom type 0 reflection to use z_v = 2h - z_source while preserving the existing input format
  • parse standard SemVer release tags in the Windows installer and separate numeric file versions from display versions
  • remove the blocking stdin read from the missing-GB-parameters error path
  • align the getting-started TOML example and documentation entry points with current behavior
  • remove the stale hard-coded release codename

Validation

  • full dev-cpu SPONGE build
  • SPONGE -v reports only the version sourced from pixi.toml
  • all 44 configured CTest tests passed; 4 existing runtime tests were skipped by configuration
  • all 10 noPBC virtual atom validation tests passed
  • mdin schema example validation passed
  • repository format-check passed
  • git diff --check passed

Windows PowerShell and NSIS packaging will be validated by the Windows release CI job.

@yuhaosimba

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-12T03:08:24.758451Z f3760de Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@xiaoxuan-yu
xiaoxuan-yu self-requested a review September 12, 2026 03:04

@xiaoxuan-yu xiaoxuan-yu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the version information in SPONGE/control.cpp for release. In particular, SPONGE_CODENAME is still set to 2026-04-01 April Fools' Day.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3760de182

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

source[0][0],
source[0][1],
2.0 * h_double - source[0][2],
2.0 * record.parameters[0] - source[0][2],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the direct Type 0 coordinate oracle

When the medium or production A/B suite runs normal_virtual_atoms_all_types, this corrected formula places fixture atom 6 at (4, 4, 3) because its source has z=1 and h=2. However, _focused_virtual_atom_coordinate_oracle() still hard-codes that atom as (4, 4, 7) at lines 17238–17240, and the input.topology.virtual_atoms path invokes that oracle at lines 13288–13293. Consequently, both otherwise-correct runtime branches now fail _assert_virtual_atom_oracle; update the direct oracle along with this rerun oracle.

Useful? React with 👍 / 👎.

@yuhaosimba yuhaosimba closed this Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants