Skip to content

test(shared): cover pagination boundaries#381

Merged
IbrahimIjai merged 1 commit into
SO4-Markets:mainfrom
0takuc0mrade:agent/issue-342-pagination-control
Jul 25, 2026
Merged

test(shared): cover pagination boundaries#381
IbrahimIjai merged 1 commit into
SO4-Markets:mainfrom
0takuc0mrade:agent/issue-342-pagination-control

Conversation

@0takuc0mrade

Copy link
Copy Markdown
Contributor

Summary

  • adds the missing shared Pagination component
  • clamps displayed page state and disables invalid previous/next navigation
  • handles multi-page, single-page, and empty result sets
  • exposes accessible navigation and button labels

Why

Upstream main did not contain the component named by the issue. The new API uses one conventional onPageChange(page) callback and native button semantics, keeping the component small and reusable.

Validation

  • focused Bun test: 4 passed
  • focused ESLint: passed
  • focused Prettier: passed
  • interaction coverage uses user-event plus role/text queries

Tests verify previous/next callback values, first/last boundaries, a single page, and zero pages.

The repository-wide checks remain affected by pre-existing upstream lint/typecheck failures outside these two new files.

Closes #342

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

@0takuc0mrade is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 25, 2026

Copy link
Copy Markdown

@0takuc0mrade Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@0takuc0mrade
0takuc0mrade marked this pull request as ready for review July 25, 2026 02:17
@IbrahimIjai
IbrahimIjai merged commit 56ee4c9 into SO4-Markets:main Jul 25, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web shared: pagination control

2 participants