Skip to content

test(trade): cover market stats header#379

Merged
IbrahimIjai merged 1 commit into
SO4-Markets:mainfrom
0takuc0mrade:agent/issue-340-market-stats-header
Jul 25, 2026
Merged

test(trade): cover market stats header#379
IbrahimIjai merged 1 commit into
SO4-Markets:mainfrom
0takuc0mrade:agent/issue-340-market-stats-header

Conversation

@0takuc0mrade

Copy link
Copy Markdown
Contributor

Summary

  • introduces the missing MarketStatsHeader component at the issue's requested path
  • formats 24-hour volume and open interest compactly through the shared USD formatter
  • formats mark and index prices through the same shared formatter
  • falls back to an em dash for missing, NaN, or infinite values

Why

Upstream main did not contain the component named by the issue. This adds the smallest presentational API needed to render already-normalized market data without duplicating formatter logic or leaking unavailable/raw values into the UI.

Validation

  • focused Bun test: 2 passed
  • focused ESLint: passed
  • focused Prettier: passed
  • tests cover a fixed market fixture and all four unavailable-value fallbacks

The repository-wide typecheck remains red from existing upstream errors in unrelated earn, pools, routes, wallet, and Soroban files; neither new file appears in that error output.

Closes #340

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

@0takuc0mrade is attempting to deploy a commit to the Ijai's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 25, 2026

Copy link
Copy Markdown

@0takuc0mrade Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@0takuc0mrade
0takuc0mrade marked this pull request as ready for review July 25, 2026 02:17
@IbrahimIjai
IbrahimIjai merged commit d95d991 into SO4-Markets:main Jul 25, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web trade: market stats header

2 participants