feat: implement spectator fly state management on game mode change#57
Open
TheBjoRedCraft wants to merge 4 commits into
Open
feat: implement spectator fly state management on game mode change#57TheBjoRedCraft wants to merge 4 commits into
TheBjoRedCraft wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements tracking/restoration of a player’s flight state when transitioning into/out of creative/spectator, ensuring prior allowFlight/isFlying values are preserved across game mode changes. Also includes a small API call adjustment for Canvas world unloading and a version bump.
Changes:
- Add
SpectatorFlyListenerto remember and restore flight settings across game mode transitions. - Register the new listener during plugin initialization.
- Switch Canvas world unload call to
Bukkit.getServer().unloadWorldAsync(...)and bump project version to3.3.8.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/kotlin/dev/slne/surf/essentials/util/world/canvas-world.kt | Adjusts the Canvas async world unload call to go through Bukkit.getServer(). |
| src/main/kotlin/dev/slne/surf/essentials/PaperListenerManager.kt | Registers the new SpectatorFlyListener. |
| src/main/kotlin/dev/slne/surf/essentials/listener/SpectatorFlyListener.kt | Adds game mode change handling to persist/restore flight permissions and flying state. |
| gradle.properties | Bumps the plugin version to 3.3.8. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…-switch' into feat/keep-fly-state-on-spectator-switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.