Feat/launcher update notification#53
Open
TheBjoRedCraft wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CoreLauncher self-update notification feature by querying the latest GitHub release once the Minecraft server is online, alongside small refactors to the existing plugin updater’s GitHub release fetch path.
Changes:
- Refactor
GitHubClient.fetchLatestReleaseto besuspendand accept a URL string, and addcheckForCoreLauncherUpdate()to print an update notice for the launcher itself. - Trigger the new core-launcher update check when the server transitions to “online”.
- Add
Implementation-Versionto the server JAR manifest and bump the project version to2.4.6.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| surf-core-launcher/surf-core-launcher-server/src/main/kotlin/dev/slne/surf/core/launcher/server/updater/process/PluginUpdater.kt | Exposes the GitHub client and updates the release fetch call to match the new GitHubClient API. |
| surf-core-launcher/surf-core-launcher-server/src/main/kotlin/dev/slne/surf/core/launcher/server/updater/github/GitHubClient.kt | Makes GitHub release fetching suspend/IO-bound and introduces the core-launcher update notification logic. |
| surf-core-launcher/surf-core-launcher-server/src/main/kotlin/dev/slne/surf/core/launcher/server/CoreLauncher.kt | Hooks the core-launcher update check into the server-online detection flow. |
| surf-core-launcher/surf-core-launcher-server/build.gradle.kts | Adds Implementation-Version to the JAR manifest to support runtime version detection. |
| gradle.properties | Bumps project version to 2.4.6. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.