Repository navigation
sync_all_siblings: sync commits always carry the account's name, not the local one - #34
Merged
Merged
Conversation
…the local one _commit_env forced the noreply e-mail but kept the local git user.name whenever one was set, so sync commits went out as <real name> <SDNick484@users.noreply.github.com>. The siblings are public and their convention is no personal names in commits either; steam-backlog's privacy scan checks commit authors against a denylist and now fails on main over the previous round's sync commit. Author and committer are now always SDNick484 and its noreply address. Refs #16 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_commit_envset the noreply e-mail on sync commits but kept the localgit config user.namewhenever one was set, soupdate --commit/--push/--prcommits went out with a real name. The siblings are public and their convention is no personal names in commits; mcp-server-steam-backlog's privacy scan checks commit authors and committers against its denylist, and itsmainCI now fails on the previous round's sync commit (e32dd73, "Sync shared to ea07617").Author and committer are now always
SDNick484 <SDNick484@users.noreply.github.com>._commit_envno longer needs the repo, so it takes no argument.Not in this PR: the earlier sync commits already on each sibling's
main(one per sibling from the ea07617 round). Rewriting a publicmainis a separate decision, raised on #16.Breaking: no. Consumers affected: none (this script isn't synced).
Test plan
test_update_pr_opens_a_pr_only_for_siblings_that_passsets a localuser.namein a sibling and asserts author and committer name and e-mail; fails on the old_commit_env, passes now🤖 Generated with Claude Code