Skip to content

sync_all_siblings: sync commits always carry the account's name, not the local one - #34

Merged
SDNick484 merged 1 commit into
mainfrom
audit/sync-commit-author
Nov 10, 2026
Merged

SDNick484 merged 1 commit into
mainfrom
audit/sync-commit-author

Conversation

@SDNick484

Copy link
Copy Markdown
Owner

Summary

_commit_env set the noreply e-mail on sync commits but kept the local git config user.name whenever one was set, so update --commit/--push/--pr commits went out with a real name. The siblings are public and their convention is no personal names in commits; mcp-server-steam-backlog's privacy scan checks commit authors and committers against its denylist, and its main CI now fails on the previous round's sync commit (e32dd73, "Sync shared to ea07617").

Author and committer are now always SDNick484 <SDNick484@users.noreply.github.com>. _commit_env no longer needs the repo, so it takes no argument.

Not in this PR: the earlier sync commits already on each sibling's main (one per sibling from the ea07617 round). Rewriting a public main is a separate decision, raised on #16.

Breaking: no. Consumers affected: none (this script isn't synced).

Test plan

  • test_update_pr_opens_a_pr_only_for_siblings_that_pass sets a local user.name in a sibling and asserts author and committer name and e-mail; fails on the old _commit_env, passes now
  • render + ruff (incl. rendered tests) + format + mypy + pytest: 356 passed

🤖 Generated with Claude Code

…the local one

_commit_env forced the noreply e-mail but kept the local git user.name
whenever one was set, so sync commits went out as <real name>
<SDNick484@users.noreply.github.com>. The siblings are public and their
convention is no personal names in commits either; steam-backlog's
privacy scan checks commit authors against a denylist and now fails on
main over the previous round's sync commit. Author and committer are
now always SDNick484 and its noreply address.

Refs #16

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant